Skip to content

Skip cypress from the UI image building process#379

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:skip-cypress-from-image-build
Nov 26, 2025
Merged

Skip cypress from the UI image building process#379
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:skip-cypress-from-image-build

Conversation

@celdrake

@celdrake celdrake commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

Cypress npm is failing today, and I realized this is also happening when building the UI images.

We can skip as it's not needed and it will be faster etc.

Summary by CodeRabbit

  • Chores
    • Updated integration testing workflow and added testing framework to development dependencies.
    • Optimized Docker build configuration to exclude test-related files.

✏️ Tip: You can customize this high-level summary in your review settings.

@celdrake

celdrake commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator Author

The pipeline still failed due to the errors returned by the Cypress npm package link, but the tests themselves could run in the CI.

@celdrake celdrake force-pushed the skip-cypress-from-image-build branch from 40c8d24 to 3512ff7 Compare November 26, 2025 13:10
@coderabbitai

coderabbitai Bot commented Nov 26, 2025

Copy link
Copy Markdown

Warning

Rate limit exceeded

@celdrake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 264d67a and 9790a78.

📒 Files selected for processing (2)
  • .dockerignore (1 hunks)
  • package.json (2 hunks)

Walkthrough

This pull request transitions the Cypress testing setup from a workspace-managed package to a direct dev dependency. The integration test scripts are updated to use a standalone Cypress installation, and Docker build context is configured to exclude the Cypress directory.

Changes

Cohort / File(s) Summary
Docker Configuration
.dockerignore
Added libs/cypress to exclude from Docker build context.
Package Configuration
package.json
Removed ./libs/cypress from workspaces array. Updated integration-tests:ci to run build:libs and start standalone service instead of running Cypress CI tests. Updated integration-tests:open to launch Cypress directly from libs/cypress directory with config file. Added Cypress ^14.0.0 as dev dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify integration-tests:ci script correctly invokes the standalone service instead of Cypress tests
  • Confirm integration-tests:open command properly references the Cypress config file path
  • Validate that Cypress ^14.0.0 is compatible with the existing test setup
  • Check that removing ./libs/cypress from workspaces doesn't break any build or test processes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR - excluding Cypress from Docker image builds by adding it to .dockerignore and removing it from workspaces.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the skip-cypress-from-image-build branch from 3512ff7 to 264d67a Compare November 26, 2025 13:11
@celdrake

Copy link
Copy Markdown
Collaborator Author

I missed adding the .dockerignore file to the branch.
Let's see if the CI Passes again.

@celdrake celdrake force-pushed the skip-cypress-from-image-build branch from 264d67a to ac34c30 Compare November 26, 2025 13:21
@celdrake celdrake requested a review from rawagner November 26, 2025 13:21
@celdrake celdrake force-pushed the skip-cypress-from-image-build branch from ac34c30 to 9790a78 Compare November 26, 2025 15:27
@celdrake celdrake merged commit 4f03c7f into flightctl:main Nov 26, 2025
6 checks passed
@celdrake celdrake deleted the skip-cypress-from-image-build branch November 26, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants