EDM-2373: Support multiple authentication providers #378
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,190 +1,166 @@ | ||||||||
| import * as React from 'react'; | ||||||||
| import { Alert, Bullseye, Spinner } from '@patternfly/react-core'; | ||||||||
|
|
||||||||
| import { AuthConfig, AuthProvider } from '@flightctl/types'; | ||||||||
| import { ProviderType } from '@flightctl/ui-components/src/types/extraTypes'; | ||||||||
| import ProviderSelector from '@flightctl/ui-components/src/components/Login/ProviderSelector'; | ||||||||
| import TokenLoginForm from '@flightctl/ui-components/src/components/Login/TokenLoginForm'; | ||||||||
| import { useFetch } from '@flightctl/ui-components/src/hooks/useFetch'; | ||||||||
| import { useTranslation } from '@flightctl/ui-components/src/hooks/useTranslation'; | ||||||||
| import { getProviderDisplayName } from '@flightctl/ui-components/src/utils/authProvider'; | ||||||||
|
|
||||||||
| import LoginPageLayout from './LoginPageLayout'; | ||||||||
| import { loginAPI } from '../../utils/apiCalls'; | ||||||||
|
|
||||||||
| const redirectToProviderLogin = async (provider: AuthProvider) => { | ||||||||
| const response = await fetch(`${loginAPI}?provider=${provider.metadata.name}`); | ||||||||
|
|
||||||||
| if (!response.ok) { | ||||||||
| throw new Error(`Login redirect failed with status ${response.status}`); | ||||||||
| } | ||||||||
|
|
||||||||
| const { url } = (await response.json()) as { url?: string }; | ||||||||
| if (!url) { | ||||||||
| throw new Error('Login redirect URL missing in response'); | ||||||||
| } | ||||||||
| window.location.href = url; | ||||||||
| }; | ||||||||
|
coderabbitai[bot] marked this conversation as resolved.
|
||||||||
|
|
||||||||
| const LoginPage = () => { | ||||||||
| const { t } = useTranslation(); | ||||||||
| const { get } = useFetch(); | ||||||||
| const [loading, setLoading] = React.useState(true); | ||||||||
| const [error, setError] = React.useState<string>(); | ||||||||
| const [providers, setProviders] = React.useState<AuthProvider[]>([]); | ||||||||
| const [userSelectedProvider, setUserSelectedProvider] = React.useState<AuthProvider | null>(null); | ||||||||
| const [defaultProviderName, setDefaultProviderName] = React.useState<string>(''); | ||||||||
| const [isRedirecting, setIsRedirecting] = React.useState(false); | ||||||||
|
|
||||||||
| const handleProviderSelect = async (provider: AuthProvider) => { | ||||||||
| // Prevent multiple clicks while redirect is in progress | ||||||||
| if (isRedirecting) { | ||||||||
| return; | ||||||||
| } | ||||||||
|
|
||||||||
| setUserSelectedProvider(provider); | ||||||||
|
Collaborator
There was a problem hiding this comment. When user tries again, we should remove the previous error
Suggested change
Collaborator
There was a problem hiding this comment. In general, the error handling did not work well if prefferedUsername was not present. Not a blocker though. |
||||||||
|
|
||||||||
| // For k8s token providers, we will show the TokenLoginForm. | ||||||||
| // For other providers, we will redirect to their OAuth flow. | ||||||||
| if (provider.spec.providerType !== ProviderType.K8s) { | ||||||||
| setIsRedirecting(true); | ||||||||
| try { | ||||||||
| await redirectToProviderLogin(provider); | ||||||||
| } catch (err) { | ||||||||
| setIsRedirecting(false); | ||||||||
| setUserSelectedProvider(null); | ||||||||
| setError( | ||||||||
| t('Failed to initiate login with {{ providerName}} ', { | ||||||||
| providerName: getProviderDisplayName(provider, t) || (provider.metadata.name as string), | ||||||||
| }), | ||||||||
| ); | ||||||||
| } | ||||||||
| } | ||||||||
| }; | ||||||||
|
celdrake marked this conversation as resolved.
|
||||||||
|
|
||||||||
| React.useEffect(() => { | ||||||||
| const loadAuthConfig = async () => { | ||||||||
| try { | ||||||||
| const config = await get<AuthConfig>('auth/config'); | ||||||||
| const providers = (config?.providers || []) | ||||||||
| .filter((provider) => provider.spec.enabled !== false) | ||||||||
| .sort((a, b) => { | ||||||||
| if (a.metadata.name === config.defaultProvider) { | ||||||||
| return -1; | ||||||||
| } | ||||||||
| if (b.metadata.name === config.defaultProvider) { | ||||||||
| return 1; | ||||||||
| } | ||||||||
| return 0; | ||||||||
| }); | ||||||||
| if (providers.length > 0) { | ||||||||
| setProviders(providers); | ||||||||
| setDefaultProviderName(config.defaultProvider || ''); | ||||||||
| if (providers.length === 1 && providers[0].spec.providerType !== ProviderType.K8s) { | ||||||||
| setIsRedirecting(true); | ||||||||
| try { | ||||||||
| await redirectToProviderLogin(providers[0]); | ||||||||
| } catch (err) { | ||||||||
| setIsRedirecting(false); | ||||||||
| setError(t('Failed to initiate login')); | ||||||||
| } | ||||||||
| } | ||||||||
| } else { | ||||||||
| setError(t('No authentication providers found. Please contact your administrator.')); | ||||||||
| } | ||||||||
| } catch (err) { | ||||||||
| setError(t('Failed to load the authentication providers')); | ||||||||
| } finally { | ||||||||
| setLoading(false); | ||||||||
| } | ||||||||
| }; | ||||||||
|
|
||||||||
| void loadAuthConfig(); | ||||||||
| // Prevent the UI going to a loop | ||||||||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||||||||
| }, []); | ||||||||
|
|
||||||||
| if (loading) { | ||||||||
| return ( | ||||||||
| <Bullseye> | ||||||||
| <Spinner size="xl" /> | ||||||||
| </Bullseye> | ||||||||
| ); | ||||||||
| } | ||||||||
|
|
||||||||
| if (error) { | ||||||||
| return ( | ||||||||
| <Bullseye> | ||||||||
| <Alert variant="danger" title="Error" isInline> | ||||||||
| {error} | ||||||||
| </Alert> | ||||||||
| </Bullseye> | ||||||||
| ); | ||||||||
| } | ||||||||
|
|
||||||||
| let content: React.ReactNode = null; | ||||||||
|
|
||||||||
| const selectedProvider = userSelectedProvider || (providers.length === 1 ? providers[0] : null); | ||||||||
| if (selectedProvider) { | ||||||||
| if (selectedProvider.spec.providerType === ProviderType.K8s) { | ||||||||
| content = ( | ||||||||
| <TokenLoginForm | ||||||||
| provider={selectedProvider} | ||||||||
| onBack={ | ||||||||
| userSelectedProvider | ||||||||
| ? () => { | ||||||||
| setUserSelectedProvider(null); | ||||||||
| } | ||||||||
| : undefined | ||||||||
| } | ||||||||
| /> | ||||||||
| ); | ||||||||
| } else { | ||||||||
| content = ( | ||||||||
| <> | ||||||||
| {t('Redirecting to login for {{ provider }}...', { | ||||||||
| provider: getProviderDisplayName(selectedProvider, t) || selectedProvider.metadata.name, | ||||||||
| })} | ||||||||
| <Spinner size="lg" /> | ||||||||
| </> | ||||||||
| ); | ||||||||
| } | ||||||||
| } else { | ||||||||
| content = ( | ||||||||
| <ProviderSelector | ||||||||
| providers={providers} | ||||||||
| defaultProviderName={defaultProviderName} | ||||||||
| onProviderSelect={handleProviderSelect} | ||||||||
| disabled={isRedirecting} | ||||||||
| /> | ||||||||
| ); | ||||||||
| } | ||||||||
|
|
||||||||
| return <LoginPageLayout>{content}</LoginPageLayout>; | ||||||||
| }; | ||||||||
|
|
||||||||
| export default LoginPage; | ||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now rather than 401 we should be getting proper statusCode 403 when the user does not have permissions, but since it's a bit unstable I'd rather keep converting 401 to 501 and disabling alerts with 401.