Skip to content

Update go to 1.24#374

Closed
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:go-1.24
Closed

Update go to 1.24#374
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:go-1.24

Conversation

@celdrake

@celdrake celdrake commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

Aligns to the backend changes in flightctl/flightctl#1921

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain requirement to version 1.24 (from 1.23).
    • Updated base container images to latest stable versions.

@coderabbitai

coderabbitai Bot commented Nov 10, 2025

Copy link
Copy Markdown

Walkthrough

Go toolchain and base image versions are updated across build configuration and module files. Both Containerfile and Containerfile.ocp receive updated image tags for the Go toolset and flightctl-base stages. The proxy/go.mod module version is bumped from 1.23.0 to 1.24.0 with matching toolchain updates. README.md prerequisite documentation is updated to reflect the Go requirement change.

Changes

Cohort / File(s) Change Summary
Build Configuration
Containerfile, Containerfile.ocp
Updated proxy-build stage Go toolset from 1.23.9-1751538372 to 1.24.6-1762373805; updated flightctl-base stage image tags to 9.6-1762316544
Go Module
proxy/go.mod
Bumped Go version from 1.23.0 to 1.24.0 and toolchain from go1.23.9 to go1.24.6
Documentation
README.md
Updated Go prerequisite requirement from >= 1.23 to >= 1.24

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify Go version consistency across all files (Containerfile, Containerfile.ocp, proxy/go.mod, README.md)
  • Confirm base image tags are properly resolved and available in the specified registries

Possibly related PRs

Suggested reviewers

  • gshilin-sdb
  • rawagner

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update go to 1.24' directly and clearly summarizes the main change across the changeset: upgrading Go from version 1.23 to 1.24 in multiple files including go.mod, Containerfiles, and README.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between edd2687 and debc1bf.

📒 Files selected for processing (4)
  • Containerfile (1 hunks)
  • Containerfile.ocp (1 hunks)
  • README.md (1 hunks)
  • proxy/go.mod (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: celdrake
Repo: flightctl/flightctl-ui PR: 371
File: libs/types/models/AppType.ts:10-10
Timestamp: 2025-10-29T16:47:29.614Z
Learning: PR #371 (flightctl/flightctl-ui) adds the AppTypeQuadlet enum member and related types as a preparatory change. Full implementation of quadlet application support in the UI will be added later, after backend support is available.
📚 Learning: 2025-02-18T12:04:42.579Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 209
File: apps/standalone/src/app/utils/apiCalls.ts:14-16
Timestamp: 2025-02-18T12:04:42.579Z
Learning: In the flightctl-ui codebase, error handling for API calls follows a React pattern where the caller component (e.g., AppToolbar.tsx) implements try-catch blocks and manages error states, rather than handling errors within the API utility functions themselves.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-04-10T12:51:20.579Z
Learnt from: celdrake
Repo: flightctl/flightctl-ui PR: 266
File: libs/ui-components/src/components/Masthead/CommandLineToolsPage.tsx:95-95
Timestamp: 2025-04-10T12:51:20.579Z
Learning: The CLI tool name is always "flightctl", regardless of whether it's in the upstream (Flight Control) or downstream (Red Hat Edge Manager) version of the product.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-02-18T12:04:42.579Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 209
File: apps/standalone/src/app/utils/apiCalls.ts:14-16
Timestamp: 2025-02-18T12:04:42.579Z
Learning: In the flightctl-ui codebase, error handling for API calls (like logout) is implemented by the caller rather than within the API utility functions themselves.

Applied to files:

  • proxy/go.mod
📚 Learning: 2025-01-07T10:11:14.375Z
Learnt from: rawagner
Repo: flightctl/flightctl-ui PR: 181
File: proxy/config/ocp.go:16-16
Timestamp: 2025-01-07T10:11:14.375Z
Learning: In the flightctl-ui repository, the `RBACNs` variable used in `proxy/config/ocp.go` is defined in `proxy/config/config.go` as a package-level variable that retrieves its value from the environment variable `K8S_RBAC_NS`.

Applied to files:

  • Containerfile.ocp
🔇 Additional comments (6)
README.md (1)

7-7: LGTM! Documentation updated correctly.

The prerequisite documentation accurately reflects the Go 1.24 requirement, aligning with the version updates in go.mod and the Containerfiles.

proxy/go.mod (1)

3-5: LGTM! Go toolchain versions updated consistently.

The Go version and toolchain declarations are properly updated and align with the go-toolset image tags (1.24.6) used in the Containerfiles.

Containerfile.ocp (2)

15-15: LGTM! Go toolset image updated correctly.

The go-toolset image version (1.24.6) matches the toolchain version specified in proxy/go.mod.


21-21: LGTM! Base image updated.

The flightctl-base image has been updated to a newer tag, likely including Go 1.24 runtime dependencies.

Containerfile (2)

15-15: LGTM! Go toolset image updated correctly.

The go-toolset image version (1.24.6) matches the toolchain version specified in proxy/go.mod and is consistent with Containerfile.ocp.


21-21: LGTM! Base image updated.

The flightctl-base image has been updated to a newer tag, consistent with Containerfile.ocp.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake requested a review from fzdarsky November 10, 2025 09:49
@celdrake

Copy link
Copy Markdown
Collaborator Author

Incorporated in #372 due to adding new go dependencies.

@celdrake celdrake closed this Nov 13, 2025
@celdrake celdrake deleted the go-1.24 branch January 20, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant