Skip to content

EDM-1939: Prevent crash when users type special characters#338

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-1939-fix-search-by-label-with-special-regexp-characters
Aug 4, 2025
Merged

EDM-1939: Prevent crash when users type special characters#338
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-1939-fix-search-by-label-with-special-regexp-characters

Conversation

@celdrake

@celdrake celdrake commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

Prevent crashing the Devices page when users type opening parenthesis/brackets in the Search field.

Summary by CodeRabbit

  • Bug Fixes
    • Improved filter functionality to handle special characters correctly when searching, ensuring accurate and reliable results.

@coderabbitai

coderabbitai Bot commented Aug 1, 2025

Copy link
Copy Markdown

Walkthrough

A utility function to escape special characters for regular expressions was introduced. The LabelFleetResults component was updated to use this function when constructing a RegExp from user-provided filter text, ensuring special characters are safely handled during pattern matching.

Changes

Cohort / File(s) Change Summary
RegExp Escaping Utility & Usage Update
libs/ui-components/src/components/Device/DevicesPage/DeviceToolbarFilters.tsx
Added escapeRegExp utility and updated RegExp construction in LabelFleetResults to use it for escaping user input.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d101d85 and 2049e46.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/Device/DevicesPage/DeviceToolbarFilters.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • libs/ui-components/src/components/Device/DevicesPage/DeviceToolbarFilters.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: integration-tests
  • GitHub Check: Lint
  • GitHub Check: Build ocp plugin
  • GitHub Check: Build
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@celdrake celdrake force-pushed the EDM-1939-fix-search-by-label-with-special-regexp-characters branch from d101d85 to 2049e46 Compare August 4, 2025 07:12
@celdrake celdrake merged commit a1ce5d2 into flightctl:main Aug 4, 2025
6 checks passed
@celdrake celdrake deleted the EDM-1939-fix-search-by-label-with-special-regexp-characters branch August 4, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants