EDM-1933: Use basic configurations can be disabled by celdrake · Pull Request #337 · flightctl/flightctl-ui

celdrake · 2025-08-01T12:53:34Z

Summary by CodeRabbit

New Features
- The update policy checkbox is now disabled when the form is in read-only mode, improving clarity for users.

coderabbitai · 2025-08-01T12:53:41Z

Walkthrough

A change was made to the UpdatePolicyStep.tsx file, specifically updating the CheckboxField component to accept an isDisabled prop, which is set according to the isReadOnly state. This ensures the checkbox is disabled when the form is in read-only mode. No other logic was changed.

Changes

Cohort / File(s)	Change Summary
UpdatePolicyStep Checkbox Read-Only Handling `libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx`	Modified the `CheckboxField` to use the `isDisabled` prop, disabling it when `isReadOnly` is true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a29004 and 1b1adb8.

📒 Files selected for processing (1)

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (8)

📓 Common learnings

Learnt from: celdrake
PR: flightctl/flightctl-ui#227
File: libs/ui-components/src/components/Device/EditDeviceWizard/EditDeviceWizard.tsx:87-87
Timestamp: 2025-03-12T09:09:44.139Z
Learning: The `getUpdatePolicyValues` function in libs/ui-components/src/components/Fleet/CreateFleet/fleetSpecUtils.ts is designed to safely handle undefined values for the updatePolicy parameter.

Learnt from: celdrake
PR: flightctl/flightctl-ui#227
File: libs/ui-components/src/components/Device/EditDeviceWizard/EditDeviceWizard.tsx:87-87
Timestamp: 2025-03-12T09:09:44.139Z
Learning: The `getUpdatePolicyValues` function in libs/ui-components/src/components/Fleet/CreateFleet/fleetSpecUtils.ts is designed to handle undefined input through its optional parameter definition and consistent use of optional chaining.

📚 Learning: the `getupdatepolicyvalues` function in libs/ui-components/src/components/fleet/createfleet/fleetspe...

Learnt from: celdrake
PR: flightctl/flightctl-ui#227
File: libs/ui-components/src/components/Device/EditDeviceWizard/EditDeviceWizard.tsx:87-87
Timestamp: 2025-03-12T09:09:44.139Z
Learning: The `getUpdatePolicyValues` function in libs/ui-components/src/components/Fleet/CreateFleet/fleetSpecUtils.ts is designed to safely handle undefined values for the updatePolicy parameter.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: the `getupdatepolicyvalues` function in libs/ui-components/src/components/fleet/createfleet/fleetspe...

Learnt from: celdrake
PR: flightctl/flightctl-ui#227
File: libs/ui-components/src/components/Device/EditDeviceWizard/EditDeviceWizard.tsx:87-87
Timestamp: 2025-03-12T09:09:44.139Z
Learning: The `getUpdatePolicyValues` function in libs/ui-components/src/components/Fleet/CreateFleet/fleetSpecUtils.ts is designed to handle undefined input through its optional parameter definition and consistent use of optional chaining.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: in flightctl, the name field is required for inline applications but optional for image-based applic...

Learnt from: celdrake
PR: flightctl/flightctl-ui#240
File: libs/ui-components/src/components/Device/DeviceDetails/DeviceApplications.tsx:44-50
Timestamp: 2025-03-19T08:55:03.335Z
Learning: In FlightCtl, the name field is required for Inline applications but optional for Image-based applications. This requirement is enforced by validation logic even though TypeScript type definitions might not explicitly show this distinction.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: in the flightctl ui components, the `useapplinks('createacmrepo')` hook is designed to always return...

Learnt from: celdrake
PR: flightctl/flightctl-ui#298
File: libs/ui-components/src/components/Device/EditDeviceWizard/steps/DeviceTemplateStep.tsx:95-100
Timestamp: 2025-06-17T09:28:36.257Z
Learning: In the FlightCtl UI components, the `useAppLinks('createAcmRepo')` hook is designed to always return a valid link for ACM deployments, so conditional rendering of LearnMoreLink components using this link is not necessary.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: in the flightctl ui project, `name` is required for inline applications but optional for image appli...

Learnt from: celdrake
PR: flightctl/flightctl-ui#240
File: libs/ui-components/src/types/deviceSpec.ts:0-0
Timestamp: 2025-03-20T12:37:36.986Z
Learning: In the FlightCtl UI project, `name` is required for inline applications but optional for image applications. This is enforced at the type level in the `InlineAppForm` type.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: in flightctl, the name field is required for inline applications but optional for image-based applic...

Learnt from: celdrake
PR: flightctl/flightctl-ui#240
File: libs/ui-components/src/components/Device/DeviceDetails/DeviceApplications.tsx:44-50
Timestamp: 2025-03-19T08:57:16.233Z
Learning: In FlightCtl, the name field is required for Inline applications but optional for Image-based applications. This requirement is enforced by both frontend validation logic and backend API constraints, ensuring that no inline application can exist in the system without a name field.

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

📚 Learning: in the flightctl ui, device tables (`enrolleddevicestable` and `decommissioneddevicestable`) are swa...

Learnt from: celdrake
PR: flightctl/flightctl-ui#208
File: libs/ui-components/src/components/Device/DevicesPage/EnrolledDevicesTable.tsx:142-150
Timestamp: 2025-02-11T10:24:15.684Z
Learning: In the FlightCtl UI, device tables (`EnrolledDevicesTable` and `DecommissionedDevicesTable`) are swapped based on the `onlyDecommissioned` state, so their respective switches can have hardcoded values (`false` and `true`).

Applied to files:

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx

🔇 Additional comments (1)

libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsx (1)

30-30: Great job adding read-only support to the basic-config checkbox

Passing isDisabled={isReadOnly} keeps the behaviour consistent with the other advanced-config toggles and prevents edits in view-only mode. Looks good.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

EDM-1933: Make basic configurations checkbox disabled if readOnly

1b1adb8

rawagner approved these changes Aug 1, 2025

View reviewed changes

celdrake merged commit cd1073d into flightctl:main Aug 4, 2025
6 checks passed

celdrake deleted the EDM-1933-use-basic-configurations-disabled branch August 4, 2025 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

EDM-1933: Use basic configurations can be disabled#337

EDM-1933: Use basic configurations can be disabled#337
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-1933-use-basic-configurations-disabled

celdrake commented Aug 1, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

celdrake commented Aug 1, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

celdrake commented Aug 1, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)