Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add with env #274

Merged
merged 4 commits into from
Mar 26, 2025
Merged

feat: 🎸 add with env #274

merged 4 commits into from
Mar 26, 2025

Conversation

MatthysDev
Copy link
Collaborator

No description provided.

@MatthysDev MatthysDev requested a review from flexbox March 26, 2025 12:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces environment-based configuration for the Spacecraft app along with updates to related documentation and the removal of the legacy JavaScript config file.

  • Adds a new TypeScript configuration (app.config.ts) that dynamically adjusts settings based on the environment.
  • Updates release challenge documentation to use the new "eas env" commands instead of the older "eas secret" commands.
  • Revises the React Navigation challenge documentation link and removes the deprecated app.config.js file.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

File Description
hackathon/spacecraft/app.config.ts Introduces environment-based configuration for the Spacecraft app.
challenges/release/02.md Updates commands to the new "eas env" syntax for managing secrets.
challenges/react-navigation/02.md Updates documentation link for route parameters.
hackathon/spacecraft/app.config.js Removes legacy configuration in favor of the new TypeScript file.
Files not reviewed (1)
  • hackathon/spacecraft/.env.local: Language not supported
Comments suppressed due to low confidence (1)

challenges/react-navigation/02.md:9

  • The link text refers to 'route prop documentation' while the URL points to 'docs/params'. Please verify that the URL accurately reflects the intended documentation for the route prop.
Check the [`route` prop documentation](https://reactnavigation.org/docs/params).

@MatthysDev MatthysDev requested a review from flexbox March 26, 2025 14:17
@MatthysDev MatthysDev assigned flexbox and unassigned MatthysDev Mar 26, 2025
@flexbox flexbox merged commit 1d6b6d4 into main Mar 26, 2025
1 check passed
@flexbox flexbox deleted the with-env branch March 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants