Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): flet -V as alternative to flet --version #4791

Merged
merged 6 commits into from
Mar 31, 2025

Conversation

tct123
Copy link
Contributor

@tct123 tct123 commented Jan 27, 2025

Description

Test Code

flet -V

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

New Features:

  • Added a "-v" shortcut to display the Flet version.

@ndonkoHenri
Copy link
Contributor

-v (or --v) is known to be for verbosity.

@FeodorFitsner
Copy link
Contributor

run command is currently configured as default parser, so flet main.py and flet run main.py are the same. This case indeed -v is conflicting with --verbose (-v is 0 verbosity and -vv is 1 verbosity).

I suggest to rename short version option to -V (uppercase).

@ndonkoHenri ndonkoHenri changed the title Update cli.py. Added '-h' feat(cli): flet -V as alternative to flet --version Feb 14, 2025
@FeodorFitsner FeodorFitsner added this to the Flet v0.27.0 milestone Feb 17, 2025
@FeodorFitsner FeodorFitsner removed this from the Flet v0.27.0 milestone Feb 20, 2025
@ndonkoHenri ndonkoHenri added this to the Flet v0.28.0 milestone Mar 3, 2025
Copy link
Contributor

@bleudev bleudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with some questions)

@FeodorFitsner FeodorFitsner merged commit 0b18221 into flet-dev:main Mar 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants