Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try using colima as the container runtime in CI #8024

Closed
wants to merge 2 commits into from
Closed

try using colima as the container runtime in CI #8024

wants to merge 2 commits into from

Conversation

roperzh
Copy link
Contributor

@roperzh roperzh commented Sep 29, 2022 •
edited
Loading

Motivation:

  • All of the macOS tests that involve installing Docker are flaky because the installation step is fragile
  • Due to a known Docker issue we have to lock the version to 4.10.0 to be able to use it in CI
  • We have spent several man-hours debugging and patching the two points above

How:

Colima is a container runtime for macOS, it's an alternative to installing the Docker.app in macOS, with great CLI support.

According to this issue actions/runner-images#6216, it will be included by default in the GitHub macOS runners soon, so we won't even have to install it.

Questions:

  • Maybe we still want to use Docker.app for fleetctl preview? this way we simulate the way that people will actually use it

@roperzh roperzh temporarily deployed to Docker Hub September 29, 2022 15:22 Inactive
@roperzh roperzh changed the title try using colima as the container runtimes in CI try using colima as the container runtime in CI Sep 29, 2022
@roperzh
Copy link
Contributor Author

roperzh commented Oct 3, 2022

going to close this as it seems it's not 100% compatible with Docker for macOS, and digging into the failed tests might take some time.

@roperzh roperzh closed this Oct 3, 2022
@roperzh roperzh mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeheath lukeheath Awaiting requested review from lukeheath lukeheath will be requested when the pull request is marked ready for review lukeheath is a code owner

@georgekarrv georgekarrv Awaiting requested review from georgekarrv georgekarrv will be requested when the pull request is marked ready for review georgekarrv is a code owner

@sharon-fdm sharon-fdm Awaiting requested review from sharon-fdm sharon-fdm will be requested when the pull request is marked ready for review sharon-fdm is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roperzh