Skip to content

Conversation

@allenhouchins
Copy link
Member

@allenhouchins allenhouchins commented Nov 18, 2025

Introduces GitHub Actions workflows to validate Fleet Maintained Apps (FMA) changes on Darwin and Windows platforms for pull requests. Adds scripts to detect changed apps and filter apps.json for targeted validation, improving CI efficiency by only testing affected apps.

Related issue: Resolves #35887

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

Database migrations

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • Verified that the setting is exported via fleetctl generate-gitops
  • Verified the setting is documented in a separate PR to the GitOps documentation
  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

Introduces GitHub Actions workflows to validate Fleet Maintained Apps (FMA) changes on Darwin and Windows platforms for pull requests. Adds scripts to detect changed apps and filter apps.json for targeted validation, improving CI efficiency by only testing affected apps.
Renamed .github/scripts/detect-changed-apps.sh to detect-new-fmas-in-pr.sh and updated all references in test-fma-darwin-pr-only.yml and test-fma-windows-pr-only.yml workflows to use the new script name. Also made minor formatting and quoting improvements in the workflow YAML files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only test newly added Fleet-maintained apps in pull requests

2 participants