Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-side logging for software installs, scripts, and setup experience #26078

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

gillespi314
Copy link
Contributor

@gillespi314 gillespi314 commented Feb 5, 2025

For #25671

NOTE: Due to the limited nature of the changes in this PR (changes to logging only), Developer QA was also limited in the interest of time. I confirmed that fleetd built successfully for three main operating systems, but only tested installation of fleetd on macOS to confirm the additional logging appeared as expected. The planned release QA process will cover all three operating systems.

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@gillespi314 gillespi314 marked this pull request as ready for review February 5, 2025 16:38
@gillespi314 gillespi314 requested a review from a team as a code owner February 5, 2025 16:38
mna
mna previously approved these changes Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 48.93617% with 24 lines in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (2b9e19f) to head (eaaf4f9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/setup_experience/setup_experience.go 0.00% 19 Missing ⚠️
orbit/pkg/installer/installer.go 76.47% 3 Missing and 1 partial ⚠️
orbit/pkg/update/notifications.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26078      +/-   ##
==========================================
- Coverage   63.64%   63.60%   -0.05%     
==========================================
  Files        1631     1631              
  Lines      156293   156430     +137     
  Branches     4088     4088              
==========================================
+ Hits        99470    99490      +20     
- Misses      48985    49101     +116     
- Partials     7838     7839       +1     
Flag Coverage Δ
backend 64.43% <48.93%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gillespi314 gillespi314 requested a review from mna February 5, 2025 21:18
@gillespi314 gillespi314 merged commit 194a8a0 into main Feb 5, 2025
46 checks passed
@gillespi314 gillespi314 deleted the 25671-fleetd-setup-experience-logging branch February 5, 2025 21:41
@PezHub
Copy link
Contributor

PezHub commented Feb 6, 2025

QA testing results:

Spot checked that software installs and script runs on all three platforms have added logging information

macOS
Screenshot 2025-02-06 at 11 25 09 AM

Win
Screenshot 2025-02-06 at 12 03 48 PM

Linux
Screenshot 2025-02-06 at 12 17 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants