-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client-side logging for software installs, scripts, and setup experience #26078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mna
previously approved these changes
Feb 5, 2025
…b.com/fleetdm/fleet into 25671-fleetd-setup-experience-logging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26078 +/- ##
==========================================
- Coverage 63.64% 63.60% -0.05%
==========================================
Files 1631 1631
Lines 156293 156430 +137
Branches 4088 4088
==========================================
+ Hits 99470 99490 +20
- Misses 48985 49101 +116
- Partials 7838 7839 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mna
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25671
NOTE: Due to the limited nature of the changes in this PR (changes to logging only), Developer QA was also limited in the interest of time. I confirmed that fleetd built successfully for three main operating systems, but only tested installation of fleetd on macOS to confirm the additional logging appeared as expected. The planned release QA process will cover all three operating systems.
Checklist for submitter
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.runtime.GOOS
).