Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retry logic to saving installation results to avoid incorrectly reporting a failure #25706

Merged
merged 11 commits into from
Jan 29, 2025

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jan 22, 2025

For #25210

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (07416c2) to head (5b1ffc6).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/installer/installer.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25706      +/-   ##
==========================================
+ Coverage   63.59%   63.60%   +0.01%     
==========================================
  Files        1622     1624       +2     
  Lines      155023   155428     +405     
  Branches     4003     4003              
==========================================
+ Hits        98580    98867     +287     
- Misses      48661    48759      +98     
- Partials     7782     7802      +20     
Flag Coverage Δ
backend 64.46% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv assigned iansltx and jahzielv and unassigned jahzielv Jan 23, 2025
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost want to recommend dropping this to 4 attempts tota because "five is right out" but...five is fine. Just a few nits.

orbit/changes/25210-falcon Outdated Show resolved Hide resolved
orbit/pkg/installer/installer.go Outdated Show resolved Hide resolved
orbit/pkg/installer/installer_test.go Outdated Show resolved Hide resolved
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge pending fleetd unfreeze

@jahzielv jahzielv marked this pull request as ready for review January 29, 2025 22:46
@jahzielv jahzielv requested a review from a team as a code owner January 29, 2025 22:46
@jahzielv jahzielv merged commit 6235642 into main Jan 29, 2025
46 checks passed
@jahzielv jahzielv deleted the 25210-falcon branch January 29, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants