Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfront URL config changes #25145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

getvictor
Copy link
Member

For #24868 (subtask)

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 67.18750% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (4c463b6) to head (3e5f304).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fleet/main.go 0.00% 19 Missing ⚠️
cmd/fleet/serve.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25145      +/-   ##
==========================================
+ Coverage   54.30%   63.83%   +9.52%     
==========================================
  Files        1615     1615              
  Lines      153594   153642      +48     
  Branches     3987     3987              
==========================================
+ Hits        83416    98073   +14657     
+ Misses      63296    47764   -15532     
- Partials     6882     7805     +923     
Flag Coverage Δ
backend 64.70% <67.18%> (+10.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review January 3, 2025 23:18
@getvictor getvictor requested a review from a team as a code owner January 3, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant