Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Add timestamps to host count on software detail pages #25143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Jan 3, 2025

Issue

For #24975

Description

  • Add last updated at counts for the software details page, os details page, and vulnerabilities details page

Screenshot of all 3

Screenshot 2025-01-03 at 4 32 04 PM Screenshot 2025-01-03 at 4 31 52 PM Screenshot 2025-01-03 at 4 31 38 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (58afb10) to head (dc96ab0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25143      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files        1615     1615              
  Lines      153602   153605       +3     
  Branches     4002     3950      -52     
==========================================
+ Hits        98043    98044       +1     
- Misses      47756    47759       +3     
+ Partials     7803     7802       -1     
Flag Coverage Δ
frontend 53.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine (though it feels like we could extract the host count tooltip message to a constant somewhere), but styling is a bit off. Which probably means tweaking the last-updated counts element.

From Figma:

host count styling

Checked the font on that item in Figma and it's showing bold rather than standard, and I'm 99% sure the font-weight on the added items isn't bold. Additionally, seems like we're missing a tiny bit of left-pading on the count element to match up with Figma (and it feels like we do need that padding). Can't eyeball this exactly (I probably could if host count was 48) but maybe 4-8px?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants