Fixing issue where deleted profiles were being sent to devices. #25095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25095 +/- ##
==========================================
+ Coverage 54.30% 63.83% +9.52%
==========================================
Files 1615 1617 +2
Lines 153594 153709 +115
Branches 3987 3987
==========================================
+ Hits 83416 98123 +14707
+ Misses 63296 47776 -15520
- Partials 6882 7810 +928
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
getvictor
changed the title
mna
approved these changes
Jan 6, 2025
|
|
||
| // BatchProcessSimple is a simple utility function to batch process a slice of payloads. | ||
| // Provide a slice of payloads, a batch size, and a function to execute on each batch. | ||
| func BatchProcessSimple[T any]( |
| @@ -260,3 +261,54 @@ WHERE | |||
| ) | |||
| return err | |||
| } | |||
|
|
|||
| // BulkDeleteHostUserCommandsWithoutResults deletes all commands without results for the given host/user IDs. | |||
There was a problem hiding this comment.
I think this is for the given "host/ command IDs", right? I see you use hostUserID elsewhere, so looks like this is deliberate, what is a hostUserID? Looks like this refers to nano's device ID?
There was a problem hiding this comment.
Just future-proofing. The nano ID is either a device ID or user ID. I assume we will support user enrollments in the future.
getvictor
added a commit
that referenced
this pull request
Jan 6, 2025
#24804 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] If database migrations are included, checked table schema to confirm autoupdate - [x] Manual QA for all new/changed functionality (cherry picked from commit 7e1a808)
getvictor
added a commit
that referenced
this pull request
Jan 6, 2025
…) (#25177) Cherry pick. For #24804 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Added/updated tests - [x] If database migrations are included, checked table schema to confirm autoupdate - [x] Manual QA for all new/changed functionality (cherry picked from commit 7e1a808)
This was referenced Jan 13, 2025
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24804
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.