Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic on missing vulnerabilities file #25081

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

mostlikelee
Copy link
Contributor

Checklist for submitter

Fixing new years bug when no vulnerabilities exist on Jan 1. Vuln job: https://github.com/fleetdm/vulnerabilities/actions/runs/12571146169/job/35041711151

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@mostlikelee mostlikelee requested a review from a team as a code owner January 1, 2025 18:52
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (5a30b47) to head (c60571c).
Report is 137 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cve/generate.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25081      +/-   ##
==========================================
+ Coverage   63.82%   63.83%   +0.01%     
==========================================
  Files        1614     1614              
  Lines      153582   153586       +4     
  Branches     4040     4040              
==========================================
+ Hits        98026    98047      +21     
+ Misses      47752    47741      -11     
+ Partials     7804     7798       -6     
Flag Coverage Δ
backend 64.71% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mostlikelee mostlikelee merged commit 0b7a1d9 into main Jan 10, 2025
22 checks passed
@mostlikelee mostlikelee deleted the vuln-new-year-bug branch January 10, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants