-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23971 Proposed API and schema changes #25013
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going to ask whether we should revise the default on me?include_settings
but it looks like loading the hosts page pulls /me
anyway so we can just revise that call to pull column settings when we need them (vs. trying to economize on HTTP requests now).
3c1a8ad
to
ff956d3
Compare
Hey @rachaelshaw, hope you had a nice vacation. Assigning you this ticket, how do these specs look from product POV? |
#23971
API changes:
this PR diff ("available_teams" change is adding missing documentation for current API behavior)
schema changes:
users
table,settings
, typejson
. Start with new setting,hidden_hosts_table_columns
semantics
"hidden_hosts_table_columns"
field means "not yet set, use defaults":{"settings":{}}
"hidden_hosts_table_columns"
field means "no columns hidden, show all columns in the UI":{"settings":{"hidden_hosts_table_columns": []}}