Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23971 Proposed API and schema changes #25013

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Dec 26, 2024

#23971

API changes:

this PR diff ("available_teams" change is adding missing documentation for current API behavior)

schema changes:

  • new col in users table, settings, type json. Start with new setting, hidden_hosts_table_columns

semantics

  • omitted "hidden_hosts_table_columns" field means "not yet set, use defaults": {"settings":{}}
  • included and empty "hidden_hosts_table_columns" field means "no columns hidden, show all columns in the UI": {"settings":{"hidden_hosts_table_columns": []}}

@jacobshandling jacobshandling changed the title 23971 Proposed API changes 23971 Proposed API and schema changes Dec 26, 2024
lucasmrod
lucasmrod previously approved these changes Dec 26, 2024
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to ask whether we should revise the default on me?include_settings but it looks like loading the hosts page pulls /me anyway so we can just revise that call to pull column settings when we need them (vs. trying to economize on HTTP requests now).

docs/REST API/rest-api.md Outdated Show resolved Hide resolved
lucasmrod
lucasmrod previously approved these changes Dec 30, 2024
@jacobshandling
Copy link
Contributor Author

Hey @rachaelshaw, hope you had a nice vacation. Assigning you this ticket, how do these specs look from product POV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants