close progress with stdin #24280
Merged
close progress with stdin #24280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Error
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Error
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
force-pushed
the
24212-fix-progress
branch
from
e7c47a9 to
d9a8308
Compare
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24280 +/- ##
==========================================
- Coverage 63.43% 63.42% -0.01%
==========================================
Files 1584 1584
Lines 150498 150621 +123
Branches 3771 3824 +53
==========================================
+ Hits 95465 95536 +71
- Misses 47415 47460 +45
- Partials 7618 7625 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
requested review from
lukeheath,
georgekarrv,
sharon-fdm and
a team
as code owners
lucasmrod
reviewed
Dec 4, 2024
orbit/pkg/luks/luks_linux.go
Outdated
| Title: infoTitle, | ||
| Text: "Validating passphrase...", | ||
| }) | ||
| if err != nil { | ||
| log.Error().Err(err).Msg("failed to show progress dialog") | ||
| } | ||
| defer func() { | ||
| if err := cancelProgress(); err != nil { | ||
| log.Error().Err(err).Msg("failed to cancel progress dialog") |
There was a problem hiding this comment.
This will error because the (stdin) file is already closed, so maybe change this one to log.Debug()? (to not create noise)
| } | ||
| } | ||
|
|
||
| // ShowEntry displays an dialog that accepts end user input. It returns the entered | ||
| // text or errors ErrCanceled, ErrTimeout, or ErrUnknown. | ||
| func (z *Zenity) ShowEntry(ctx context.Context, opts dialog.EntryOptions) ([]byte, error) { | ||
| z.killZenityFunc() |
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
@sharon-fdm need a review from you as it's updating CI to use macos-13 (macos-12 is EOL) |
sharon-fdm
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24212
The zenity progress window expects stdin to update and close the window, this caused a few issues where
creating a
StdinPipe()and closing it fixes both issueschanges/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
runtime.GOOS).