Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch: Windows MDM migration #24262

Merged
merged 12 commits into from
Dec 3, 2024
Merged

Conversation

mna
Copy link
Member

@mna mna commented Dec 2, 2024

Feature branch for the #22075 story.

ghernandez345 and others added 4 commits November 22, 2024 16:52
relates to #22896

Implements the UI for the windows automatic migration.

**new windows mdm page layout with automatic migration checkbox**


![image](https://github.com/user-attachments/assets/2909d6d2-e802-4dec-9c78-0b8f6a4466c0)

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [ ] Added/updated tests
- [x] Manual QA for all new/changed functionality
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 60.17699% with 45 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (941713d) to head (15a8214).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...150614_AddAppConfigWindowsMigrationEnabledField.go 37.14% 16 Missing and 6 partials ⚠️
server/service/osquery_utils/queries.go 18.18% 7 Missing and 2 partials ⚠️
...e/cards/ActivityFeed/ActivityItem/ActivityItem.tsx 0.00% 8 Missing ⚠️
server/service/appconfig.go 85.00% 2 Missing and 1 partial ⚠️
server/service/orbit.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24262      +/-   ##
==========================================
- Coverage   63.43%   63.43%   -0.01%     
==========================================
  Files        1582     1583       +1     
  Lines      150353   150483     +130     
  Branches     3822     3824       +2     
==========================================
+ Hits        95381    95459      +78     
- Misses      47373    47416      +43     
- Partials     7599     7608       +9     
Flag Coverage Δ
backend 64.30% <64.76%> (-0.01%) ⬇️
frontend 52.65% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review December 2, 2024 21:28
@mna mna requested review from rachaelshaw and a team as code owners December 2, 2024 21:28
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving frontend changes based on prior PR reviews.

@mna mna requested a review from noahtalerman December 3, 2024 16:22
Copy link
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Audit logs contributor doc page looks good!

@mna mna merged commit 1d365ee into main Dec 3, 2024
34 checks passed
@mna mna deleted the feat-automatic-migrate-windows-hosts branch December 3, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants