collapsible side panel #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try it live or on a phone: |
|
The live preview link is dead for me @magland: |
|
@WardBrian this is due to #89 |
|
Yep, that worked. |
jsoules
reviewed
Jun 27, 2024
Comment on lines
48
to
58
| const lastWidth = useRef(width) | ||
| useEffect(() => { | ||
| if (!determineShouldBeInitiallyCollapsed(lastWidth.current) && determineShouldBeInitiallyCollapsed(width)) { | ||
| lastWidth.current = width | ||
| setLeftPanelCollapsed(true) | ||
| } | ||
| else if (determineShouldBeInitiallyCollapsed(lastWidth.current) && !determineShouldBeInitiallyCollapsed(width)) { | ||
| lastWidth.current = width | ||
| setLeftPanelCollapsed(false) | ||
| } | ||
| }, [width]) |
There was a problem hiding this comment.
Since all we care about for lastWidth is whether it implies a collapsed state, this could probably be simplified (reducing function calls) as something along the lines of:
const isCollapsed = useRef(determineShouldBeInitiallyCollapsed(width));
useEffect(() => {
const shouldBeCollapsed = determineShouldBeInitiallyCollapsed(width);
if (isCollapsed.current !== shouldBeCollapsed) {
isCollapsed.current = shouldBeCollapsed;
setLeftPanelCollapsed(shouldBeCollapsed);
}
}, [width])There was a problem hiding this comment.
I think your isCollapsed variable should really be named something like lastShouldBeCollapsed. Either way it's somewhat confusing. I think I'd prefer to stick with what I have.
There was a problem hiding this comment.
Thinking more about it, I think your simplification is clearer. I essentially used your code but I used the name lastShouldBeCollapsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #86
Implement collapsible/expandable left panel.
Upon initial load, determines if width is too small (like on a device) and defaults to a collapsed panel.
When panel is collapsed there's a chevron button you can press or click to expand.
When expanded, width is determined based on overall width based on a formula.
When expanded, there's a chevron button you can press or click to collapse.
AND advanced: when resizing a browser window and you transition from large-enough to too-small the panel automatically collapses. Similarly when you transition from too-small to large-enough the panel automatically expands.
This is the functionality that I felt was most natural.