Fix downloading monaco twice per load #267
Conversation
| const widgetPosition = { | ||
| position: { lineNumber: 1, column: 1 }, | ||
| preference: [monacoInstance.editor.ContentWidgetPositionPreference.EXACT], | ||
| }; |
There was a problem hiding this comment.
Seems like this ought to be const-able, but the linter doesn't like it. Probably doesn't matter anyway...
There was a problem hiding this comment.
Not sure I follow what you mean by const-able in this context?
There was a problem hiding this comment.
I mean annotated as as const, since its members don't seem to be able to be changed anywhere in the code. But that conflicts with the looser typing further down.
(The larger context was me wondering if it should be memoized, before realizing this was already in a useEffect hook, so it doesn't matter.)
|
(Noting that Monaco still loads in this version, and is noticeably faster to do so...) |
Specifying the URL is necessary if you want control over the version. So far we have (unknowingly!) always been using monaco-loader's default version, which is 0.46 |
...weird. Wonder why they're so far behind... |
|
From what I can tell, historically, requests for them to bump their default version are met with people being told just to use the config like this. I think they want to avoid doing an npm release every time monaco does one |
Co-authored-by: Jeff Soules <[email protected]>
|
What must their release schedule be like, that that would be an actual problem greater than everybody by default using a version from 2023 |
|
Well, we were using a version from 2023 and didn't notice... ;P |
I noticed some slow loading during a dev environment that made me inspect the network tab and realize monaco was not loading from
localhost, but from a CDN.After some digging, it turns out
@monaco-editor/reactuses a package called@monaco-editor/loaderthat has this behavior. I was unsuccessful in getting it to use our bundled monaco, so instead I went the other way and made it so we don't have to bundlemonaco-editorourselves at all.The bundle size is much happier now, here's yarn build: