-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize frontend folder structure, nomeclature #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few recommended changes, a few relevant comments, and some less relevant ones...
Overall looks good. I've pulled and run locally and everything still seemed to be present & loaded fine, as far as I could tell.
@@ -53,7 +59,7 @@ const StanFileEditor: FunctionComponent<Props> = ({ | |||
}); | |||
|
|||
// invalid syntax | |||
if (!validSyntax && !!editedFileContent) { | |||
if (!validSyntax && !!data.ephemera.stanFileContent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly germane to this PR, but my fingers are itching to move the button stuff to its own file, or at least find a way to make it less repetitive.
@@ -59,7 +69,22 @@ const TopBar: FunctionComponent<TopBarProps> = ({ title, onSetCollapsed }) => { | |||
<Brightness7 fontSize="inherit" /> | |||
)} | |||
</IconButton> | |||
<CompilationServerConnectionControl /> | |||
<IconButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inlining this component (from CompilationServerConnectionControl) is not unreasonable, it isn't super big, but it's somewhat less semantic.
Co-authored-by: Jeff Soules <[email protected]>
This closes #113. This just moves code around and renames some things, no behavioral changes
The organizing principles are defined in a new ARCHITECTURE.md document: link
src/app
now has the following top-level folders:pages
-- just HomePageareas
-- sub-views of HomePage. The majority of the UI is here and its sub-folderswindows
-- modal boxes that show up above HomePage, like the settingscomponents
-- reusable componentscore
-- contexts and workers, non-UI codeutil
-- utility functionsFor easier viewing, here's the folder layout in full:
Details