Show which files are unsaved on disabled save/load buttons #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoules
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Code changes are reasonable and the behavior in the UI appears to match what is intended.
However, it seems a little weird that the "save project" button gets disabled if there are unsaved files. On reflection it makes sense; "Save Project" in that context means "persist the project to one of our sharing/reloading mechanisms," not "save the unchanged changes in the editor," and it's good to disallow an action when the results would be potentially unintuitive.
But I wonder if there's another word we can use for the "save project" button to get around the friction of a "save" button complaining about unsaved content...
|
"Export" seems like the obvious synonym? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also cleans up a bit of dataflow where a component was receiving a redundant piece of information as an argument which it already had access to internally