Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for ess and R-hat based on Stan's #221

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

WardBrian
Copy link
Collaborator

Half of #69

Just using known values from Stan's tests

@magland
Copy link
Collaborator

magland commented Oct 2, 2024

Looks good to me. It's a shame to check in those large files, but as long as they don't change often I think it's fine.

@WardBrian
Copy link
Collaborator Author

Stan has been testing against these same files for 11 years, so I think we're probably fine there!

If we do touch this again, it will likely be to move it to another package entirely.

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit opaque, but seeing as it's imported directly from the Stan test suite and has been stable for over a decade, I'm okay to merge it.

@WardBrian WardBrian merged commit 7f6b8ff into main Oct 2, 2024
2 checks passed
@WardBrian WardBrian deleted the tests/rhat-ess branch October 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants