Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add me.alexdevs.Capy64 #4355

Closed
wants to merge 47 commits into from
Closed

Add me.alexdevs.Capy64 #4355

wants to merge 47 commits into from

Conversation

Ale32bit
Copy link

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

matthiasclasen and others added 30 commits April 4, 2017 06:07
Add more requirements for building applications, and explain how to install apps that are hosted here.
Add a link to the website.
Reduce the duplication. We still explain the basic setup here, but refer to the review guidelines for details.
Make URL nicer, remove newlines from the end
Changed protocol from http to https on flathub url because on http flathub reports errors.
I almost opened an issue here due to misunderstanding what this repo is for.

See also: flathub-infra/linux-store-frontend#167
README.md: send people looking for website repo to linux-store-frontend
@Ale32bit
Copy link
Author

bot, build me.alexdevs.Capy64

@flathubbot
Copy link

Queued test build for me.alexdevs.Capy64.

@flathubbot
Copy link

Started test build 54869

@flathubbot
Copy link

Build 54869 failed

@Ale32bit
Copy link
Author

bot, build me.alexdevs.Capy64

@flathubbot
Copy link

Queued test build for me.alexdevs.Capy64.

flathub.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file.

"--share=ipc",
"--socket=pulseaudio",
"--device=dri",
"--filesystem=xdg-data/Capy64",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 17: why do you need this?

@flathubbot
Copy link

Started test build 54874

"append-path":"/usr/lib/sdk/dotnet7/bin",
"append-ld-library-path":"/usr/lib/sdk/dotnet7/lib",
"env":{
"PKG_CONFIG_PATH":"/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig:/usr/lib/sdk/dotnet7/lib/pkgconfig"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use append-pkg-config-path instead.

@flathubbot
Copy link

Build 54874 failed

msources.json Outdated
},
{
"type": "file",
"url": "https://globalcdn.nuget.org/packages/microsoft.netcore.app.host.linux-x64.7.0.9.nupkg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this work on aarch64?

Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desktop file, icon and appdata files should be submitted for inclusion upstream.

appdata.xml Outdated
</p>
</description>

<launchable type="desktop-id">me.alexdevs.Capy64.desktop</launchable>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing required content_rating, url, releases and screenshots

"command":"start-capy64",
"finish-args":[
"--socket=x11",
"--socket=wayland",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really support wayland?

Capy64.desktop Outdated
Categories=Game;Emulator;

Icon=me.alexdevs.Capy64
Exec=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing exec

@Ale32bit Ale32bit closed this Jul 24, 2023
@Ale32bit Ale32bit force-pushed the capy64 branch 2 times, most recently from be246fe to 1963c89 Compare July 24, 2023 16:11
@Ale32bit Ale32bit deleted the capy64 branch July 24, 2023 16:15
@Ale32bit Ale32bit restored the capy64 branch July 24, 2023 16:20
@Ale32bit Ale32bit deleted the capy64 branch July 24, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.