Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /etc/static/shells before than /etc/shells #428

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jcleng
Copy link

@jcleng jcleng commented Aug 25, 2023

Create /etc/static/shells before than /etc/shells, because /etc/shells ls linkd etc/static/shells.
when use nixos is default has't /etc/static/shells

2023-08-25 23:55:24.648 [error] ENOENT: no such file or directory, open '/etc/shells': Error: ENOENT: no such file or directory, open '/etc/shells'
2023-08-25 23:55:26.631 [error] ENOENT: no such file or directory, open '/etc/shells': Error: ENOENT: no such file or directory, open '/etc/shells'

this error cause it not to take effect "terminal.integrated.defaultProfile.linux": "bash",
#227

Create /etc/static/shells before than /etc/shells, because /etc/shells ls linkd etc/static/shells.
 when use nixos is default has't /etc/static/shells
@flathubbot
Copy link
Contributor

Started test build 61106

@flathubbot
Copy link
Contributor

Build 61106 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/43743/com.visualstudio.code.flatpakref

@jcleng
Copy link
Author

jcleng commented Sep 6, 2023

/merge

@flathubbot
Copy link
Contributor

Started test build 64664

@flathubbot
Copy link
Contributor

Build 64664 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47298/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 66309

@flathubbot
Copy link
Contributor

Build 66309 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/48966/com.visualstudio.code.flatpakref

@Tomaszal
Copy link

Is there any reason this isn't merged yet?

Copy link

@Tomaszal Tomaszal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few changes which I think should make this more practical to be included in the flatpak

EDIT: ignore the one on the top, posted an empty one accidentally

code.sh Show resolved Hide resolved
code.sh Show resolved Hide resolved
@flathubbot
Copy link
Contributor

Started test build 85191

@flathubbot
Copy link
Contributor

Build 85191 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67840/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 86144

@flathubbot
Copy link
Contributor

Build 86144 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/68807/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 86530

@flathubbot
Copy link
Contributor

Build 86530 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/69190/com.visualstudio.code.flatpakref

@flathubbot
Copy link
Contributor

Started test build 86532

@flathubbot
Copy link
Contributor

Build 86532 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/69192/com.visualstudio.code.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants