Skip to content

benchmark: Make use_cupti the default in microbenchmarks. #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yzh119 merged 1 commit into from
Dec 6, 2025
Merged

benchmark: Make use_cupti the default in microbenchmarks. #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion benchmarks/flashinfer_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ def parse_args(line=sys.argv[1:]):
"--use_cupti",
action="store_true",
default=False,
help="Use CUPTI for timing GPU kernels when available.",
help="[DEPRECATED] Use CUPTI for timing GPU kernels. This is now the default behavior.",
)
parser.add_argument(
"--use_cuda_events",
action="store_true",
default=False,
help="Use CUDA events for timing GPU kernels instead of CUPTI.",
)
parser.add_argument(
"--refcheck",
Expand Down Expand Up @@ -155,6 +161,16 @@ def parse_args(line=sys.argv[1:]):

if args.generate_repro_command:
args.repro_command = "python3 flashinfer_benchmark.py " + " ".join(line)

# Deprecation warning for use_cupti
if args.use_cupti:
print(
"[WARNING] --use_cupti is deprecated and will be removed in a future release. CUPTI is now enabled by default."
)
# use_cupti is deprecated and will be removed in a future release. CUPTI is now enabled by default.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment is redundant as it almost exactly repeats the warning message printed on line 168 for the deprecated --use_cupti flag. It can be removed to improve code clarity and reduce noise.

# If --use_cuda_events is passed, disable use_cupti
args.use_cupti = not args.use_cuda_events

return args


Expand Down