-
Notifications
You must be signed in to change notification settings - Fork 324
bugfix: import wrapper of mla decode #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing jenkins check seems not caused by compilation error, the last several lines of the log:
Can this check re-run? |
Hi @dhy2000 , we encourage using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the lint error (https://github.com/flashinfer-ai/flashinfer/actions/runs/14374651614/job/40334288048?pr=1013), Please format your code with pre-commit.
Thanks, so is it necessary to keep the |
adef1b7
to
75b4f64
Compare
Lint fixed. |
75b4f64
to
96638ea
Compare
We can keep it until fully deprecate this function. |
In
tests/test_mla_decode_kernel.py
, the code below usesBatchDecodeMlaWithPagedKVCacheWrapper
:flashinfer/tests/test_mla_decode_kernel.py
Lines 348 to 355 in f579ca2
However an AttributeError is thrown:
Because the module
flashinfer
does not importBatchDecodeMlaWithPagedKVCacheWrapper
from submodule.decode
and export it.This patch can solve it.