Skip to content

publish bids to redis async #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

publish bids to redis async #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions services/bidcollect/bid-processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ type BidProcessor struct {
csvFileEnding string

redisClient *redis.Client
redisC chan *types.CommonBid
}

func NewBidProcessor(opts *BidProcessorOpts) (*BidProcessor, error) {
Expand All @@ -58,6 +59,7 @@ func NewBidProcessor(opts *BidProcessorOpts) (*BidProcessor, error) {
outFiles: make(map[int64]*OutFiles),
bidCache: make(map[uint64]map[string]*types.CommonBid),
topBidCache: make(map[uint64]*types.CommonBid),
redisC: make(chan *types.CommonBid, 10),
}

if opts.OutputTSV {
Expand All @@ -84,6 +86,12 @@ func NewBidProcessor(opts *BidProcessorOpts) (*BidProcessor, error) {
}

func (c *BidProcessor) Start() {
// If needed, start publish worker
if c.opts.RedisAddr != "" {
go c.redisPublishWorker()
}

// Main loop
for {
time.Sleep(30 * time.Second)
c.housekeeping()
Expand Down Expand Up @@ -120,11 +128,12 @@ func (c *BidProcessor) processBids(bids []*types.CommonBid) {
isNewBid = true
}

// Send to Redis
if c.redisClient != nil {
err := c.redisClient.Publish(context.Background(), types.RedisChannel, bid.ToCSVLine(",")).Err()
if err != nil {
c.log.WithError(err).Error("failed to publish bid to redis")
// Publish bid to Redis (async)
select {
case c.redisC <- bid:
default:
c.log.Warnf("redis channel full, dropping bid %s", bid.UniqueKey())
}
}

Expand All @@ -133,6 +142,15 @@ func (c *BidProcessor) processBids(bids []*types.CommonBid) {
}
}

func (c *BidProcessor) redisPublishWorker() {
for bid := range c.redisC {
err := c.redisClient.Publish(context.Background(), types.RedisChannel, bid.ToCSVLine(",")).Err()
if err != nil {
c.log.WithError(err).Error("failed to publish bid to redis")
}
}
}

func (c *BidProcessor) writeBidToFile(bid *types.CommonBid, isNewBid, isTopBid bool) {
fAll, fTop, err := c.getFiles(bid)
if err != nil {
Expand Down