add metrics to track gas used by reverting txs #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
SozinM,
avalonche and
karim-agha
as code owners
avalonche
reviewed
Sep 23, 2025
| if result.is_success() { | ||
| log_txn(TxnExecutionResult::Success); | ||
| num_txs_simulated_success += 1; | ||
| self.metrics.successful_tx_gas_used.record(gas_used as f64); |
There was a problem hiding this comment.
does this not need reverted_gas_used += gas_used?
avalonche
reviewed
Sep 23, 2025
| } | ||
|
|
||
| impl OpRBuilderMetrics { | ||
| #[expect(clippy::too_many_arguments)] |
There was a problem hiding this comment.
can group these metrics as a struct instead of adding more args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
So we have a good idea of how much execution resources is taken up by reverting txs
💡 Motivation and Context
Unfortunately reth only tracks gas used by blocks, which isn't accurate for us since we don't include reverting txs in the block: https://github.com/paradigmxyz/reth/blob/main/crates/evm/evm/src/metrics.rs
✅ I have completed the following steps:
make lintmake test