Add reproducible builds #233
Open
+113
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
requested review from
ferranbt,
avalonche and
karim-agha
as code owners
SozinM
force-pushed
the
msozin/make-release-reproducible
branch
from
6fae7bb to
cb9b9c8
Compare
SozinM
changed the title
alexhulbert
requested changes
Aug 13, 2025
alexhulbert
approved these changes
Aug 13, 2025
|
@SozinM manually requesting you to review since Github won't let me request your review on your own PR |
SozinM
commented
Aug 14, 2025
SozinM
commented
Aug 14, 2025
SozinM
commented
Aug 14, 2025
…msozin/make-release-reproducible
alexhulbert
force-pushed
the
msozin/make-release-reproducible
branch
from
12bae3d to
4a23f25
Compare
alexhulbert
force-pushed
the
msozin/make-release-reproducible
branch
4 times, most recently
from
d5d231e to
094d496
Compare
alexhulbert
force-pushed
the
msozin/make-release-reproducible
branch
from
094d496 to
f58cb33
Compare
|
Should be good now! @SozinM can you give it another check over? |
There was a problem hiding this comment.
suggestion:
please add op_rbuilder_ prefix to this file to namespace it
|
|
||
| jobs: | ||
| verify: | ||
| name: Verify reproducible builds |
There was a problem hiding this comment.
suggestion:
Suggested change
| name: Verify reproducible builds | |
| name: "[op-rbuilder ]Verify reproducible builds" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
From reth
https://github.com/paradigmxyz/reth/blob/f30016019d592e36b31b48feb8adf3292c04b626/Makefile#L83
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test