-
Couldn't load subscription status.
- Fork 65
Add ChangeUnitConstructor annotation to allow mongock to pick constructors for dependency injection #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We'll take a look today ;). Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! looks good, just a couple of minor changes before merging 😃
.../mongock-runner-core/src/main/java/io/mongock/runner/core/executor/ChangeLogRuntimeImpl.java
Show resolved
Hide resolved
.../mongock-runner-core/src/main/java/io/mongock/runner/core/executor/ChangeLogRuntimeImpl.java
Show resolved
Hide resolved
|
@thekaleidoscope we have approved this PR, so now you can merge it. Thanks for collaborating with Mongock! |
|
@osantana85 Thanks, I don't see how to do it though, It says |
|
@thekaleidoscope Ok, no problem, it's just about permissions. I'll merge it. Thanks. |
Issue reference
508
Documentation PR reference
38
Description and context
Used Optionals and Stream for null safe iterations
Benefits
[What benefits will be realized by the code change?]
Improve existing exceptions, add ability to specify which constructor to inject dependencies to.
Possible Drawbacks
[What are the possible side-effects or negative impacts of the code change?]
None I can think of.
Checklist