Skip to content

Conversation

@thekaleidoscope
Copy link
Contributor

@thekaleidoscope thekaleidoscope commented Jun 19, 2022

Issue reference

508

Documentation PR reference

38

Description and context

Used Optionals and Stream for null safe iterations

Benefits

[What benefits will be realized by the code change?]

Improve existing exceptions, add ability to specify which constructor to inject dependencies to.

Possible Drawbacks

[What are the possible side-effects or negative impacts of the code change?]

None I can think of.

Checklist

@thekaleidoscope thekaleidoscope requested a review from dieppa as a code owner June 19, 2022 08:34
@dieppa
Copy link
Member

dieppa commented Jun 21, 2022

We'll take a look today ;).

Thanks

@dieppa dieppa requested a review from osantana85 June 21, 2022 11:47
Copy link
Member

@dieppa dieppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks good, just a couple of minor changes before merging 😃

@osantana85
Copy link
Member

@thekaleidoscope we have approved this PR, so now you can merge it. Thanks for collaborating with Mongock!

@thekaleidoscope
Copy link
Contributor Author

@osantana85 Thanks, I don't see how to do it though, It says Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests. In the past I saw @dieppa had merged the MRs

@osantana85
Copy link
Member

@thekaleidoscope Ok, no problem, it's just about permissions. I'll merge it. Thanks.

@osantana85 osantana85 merged commit 46923b3 into flamingock:develop Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants