refactor CWE-416 check (#429)

fkie-cad · Sep 4, 2023 · 270b4d4 · 270b4d4
1 parent 2e11e84
commit 270b4d4
Show file tree

Hide file tree

Showing 5 changed files with 248 additions and 345 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,8 @@
 0.8-dev
 ===
 
+-   Improve logic and context information generation of CWE-416 (use-after-free) check (PRs #423, #429)
+
 0.7 (2023-06)
 ====
 

diff --git a/Cargo.toml b/Cargo.toml
@@ -1,2 +1,3 @@
 [workspace]
 members = ["src/cwe_checker_lib", "src/caller", "test", "src/installer"]
+resolver = "2"
diff --git a/src/cwe_checker_lib/src/checkers/cwe_416/context.rs b/src/cwe_checker_lib/src/checkers/cwe_416/context.rs
@@ -76,7 +76,7 @@ impl<'a> Context<'a> {
         state: &mut State,
         call_tid: &Tid,
         call_params: impl IntoIterator<Item = &'b Arg>,
-    ) -> Option<Vec<(AbstractIdentifier, Tid)>> {
+    ) -> Option<Vec<(AbstractIdentifier, Vec<Tid>)>> {
         let mut warnings = Vec::new();
         for arg in call_params {
             if let Some(arg_value) = self
@@ -174,7 +174,7 @@ impl<'a> Context<'a> {
         name: &str,
         description: String,
         location: &Tid,
-        warning_causes: Vec<(AbstractIdentifier, Tid)>,
+        warning_causes: Vec<(AbstractIdentifier, Vec<Tid>)>,
         root_function: &Tid,
     ) {
         let cwe_warning = CweWarning {