Skip to content

Conversation

@fjlaubscher
Copy link
Owner

Summary

  • set up GitHub Actions for building and linting with Prettier
  • add a separate workflow to run Vitest

Testing

  • yarn prettier --check .
  • yarn vitest run --passWithNoTests

https://chatgpt.com/codex/tasks/task_e_6842ce9203e4832690dcbd5a4fc87329

@fjlaubscher fjlaubscher requested a review from Copilot June 6, 2025 11:27
@fjlaubscher fjlaubscher self-assigned this Jun 6, 2025
@fjlaubscher fjlaubscher merged commit 011f47e into main Jun 6, 2025
2 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces CI workflows for automated building, linting with Prettier, and running Vitest, and pins the project to a specific Yarn version.

  • Add a packageManager field in package.json to enforce Yarn 1.22.22.
  • Create a Test workflow (.github/workflows/test.yml) to run Vitest on pushes and PRs.
  • Create a Build and Lint workflow (.github/workflows/build.yml) to run Prettier checks and build on pushes and PRs.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
package.json Added packageManager entry for consistent Yarn use.
.github/workflows/test.yml New workflow to install deps and run Vitest tests.
.github/workflows/build.yml New workflow to install deps, check Prettier, and build.

- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22'
Copy link

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node version '22' may not be supported on the hosted runner; consider using a published LTS like '18.x' or '20.x'.

Suggested change
node-version: '22'
node-version: '20.x'

Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22'
Copy link

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node version '22' may not be supported on the hosted runner; consider using a published LTS like '18.x' or '20.x'.

Suggested change
node-version: '22'
node-version: '20'

Copilot uses AI. Check for mistakes.
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copy link

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The checkout, setup-node, and install steps are duplicated across workflows. Consider extracting them into a reusable workflow or composite action to reduce repetition.

Copilot uses AI. Check for mistakes.
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copy link

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The checkout, setup-node, and install steps are duplicated across workflows. Consider extracting them into a reusable workflow or composite action to reduce repetition.

Copilot uses AI. Check for mistakes.
@fjlaubscher fjlaubscher deleted the codex/add-github-workflows-for-build,-lint-and-tests branch June 6, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant