Skip to content

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Aug 7, 2025

PR Overview

Package version introduced in this PR:

  • v0.21.0-a1
  • v0.21.2-a1

A case could be made for this to be v0.20.1-a1 but it is in actuality rather breaking

This PR addresses the following Issue/Feature(s):

  • Closes out GA-1000203

Summary of changes:

  • Changes the default value of shopify_api to graphql so that Quickstart folks can try this out

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)

Confirmed that dbt run without setting the shopify_api var runs the graphql models

  • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-jamie fivetran-jamie added the docs:ready Triggers the docs generator workflow. label Aug 7, 2025
@fivetran-jamie fivetran-jamie self-assigned this Aug 7, 2025
@fivetran-jamie fivetran-jamie marked this pull request as ready for review August 7, 2025 19:42
packages.yml Outdated
Comment on lines 2 to 6
# - package: fivetran/shopify_source
# version: 0.20.0-a1
# - local: ../ECommerce/Shopify/dbt_shopify_source
- git: https://github.com/fivetran/dbt_shopify_source.git
revision: update/graphql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update

@fivetran-jamie fivetran-jamie added the pre-release Triggers the auto-releaser workflow. label Aug 11, 2025
packages.yml Outdated
Comment on lines 2 to 6
# - package: fivetran/shopify_source
# version: 0.20.1-a1
# - local: ../ECommerce/Shopify/dbt_shopify_source
- git: https://github.com/fivetran/dbt_shopify_source.git
revision: update/graphql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update

@fivetran-jamie fivetran-jamie added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. labels Sep 4, 2025
@fivetran-jamie fivetran-jamie added the pre-release Triggers the auto-releaser workflow. label Sep 4, 2025
@fivetran-jamie fivetran-jamie added the type:wontfix This will not be worked on label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow. pre-release Triggers the auto-releaser workflow. type:wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants