-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 (without rebase) #29
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to include accounts beginning with "_"
Update to include accounts beginning with "_"
Merged
Thanks. I've just posted the latest version of the data (#28) that @patrick-lee-warren sent us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at this one which is the vanilla version. If this is acceptable, I will rebase this (merging it down to one commit). This will reduce the load on the repo moving forward by gigs compared to this version here without the rebase. We will lose commit history.
If rewriting the repo is acceptable, perhaps we should just publish a version 2.0 and mark this whole repo as deprecated and move people over to that. In a version 2.0 repo changes would be text-only, and we wouldn't be carrying around gigs of compressed files and bad commits.
Remember removing a file from the head of a tree does not delete it, all of old commits are still here.
This version has the PostgreSQL schema, loader, and dumper and improves on prior version 2.0 by removing duplicates.