Fieldsplit: update MatNest Jacobian and support bcs on AssembledMatrix #4708
+165
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
7c9dfcc to
aaabace
Compare
pbrubeck
changed the title
pbrubeck
commented
Nov 5, 2025
firedrake/solving_utils.py
Outdated
Comment on lines
517
to
524
| # Bump petsc matrix state of each split by assembling them. | ||
| # Ensures that if the matrix changed, the preconditioner is | ||
| # updated if necessary. | ||
| for field, splits in ctx._splits.items(): | ||
| for subctx in splits: | ||
| subctx._jac.assemble() | ||
| if subctx.Jp is not None: | ||
| subctx._pjac.assemble() |
Contributor
Author
There was a problem hiding this comment.
@stefanozampini I think this should be called elsewhere, maybe in pyop2 or PETSc, but so far this fixes the bug #4687. This is very similar to what we had to do for MatIS
firedrake/firedrake/assemble.py
Lines 1496 to 1498 in 0ce9ad2
JHopeCollins
reviewed
Nov 5, 2025
pbrubeck
commented
Nov 5, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/nest-fieldsplit
branch
from
abddfda to
4ab9490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4687
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/8860 to trigger preconditioner update for a MatNest with more than one field on a block of the fieldsplit.
Also fixes fieldsplit for
AssembledMatrixwith bcsCleanup
create_subdmindmhooks.py