Skip to content

Conversation

@aaron-ang
Copy link

@aaron-ang aaron-ang commented Jan 6, 2026

use VmmActions with (entrypoint, args) tuples and spec struct suffix.

Changes

  • Renamed public VMM inputs from *Config/cfg to *Spec/spec. Using “spec” suffix makes the contract explicit.
  • VMM entry points take static specs as arguments, while internal state is derived privately.

Reason

Address a TODO regarding public-facing VMM structs. See #3273.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@aaron-ang aaron-ang marked this pull request as ready for review January 6, 2026 07:07
@aaron-ang aaron-ang changed the title fix: use stateless structs for public VMM code fix: resolve TODO to use stateless structs for public VMM code Jan 6, 2026
use VmmActions with (entrypoint, args) tuples and `spec` struct suffix.

Signed-off-by: Aaron Ang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant