Skip to content

Support reset for net device #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acj wants to merge 6 commits into from
Closed

Support reset for net device #4389

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fefe31c
vmm: Add ResetError type
acj Jan 31, 2024
4419bb8
vmm: Refactor reset func to use ResetError
acj Jan 31, 2024
88512b9
vmm: Implement basic reset capability for net device
acj Jan 31, 2024
71c2a07
vmm: Add device reset metric
acj Jul 30, 2025
ff9dc0d
vmm: Reset device queues and TX/RX buffers
acj Aug 7, 2025
d178d20
tests: Add integration test for resetting a net device
acj Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/vmm/src/devices/virtio/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ pub enum ActivateError {
QueueMemoryError(QueueError),
}

// Errors triggered when resetting a VirtioDevice.
#[derive(Debug, thiserror::Error, displaydoc::Display)]
pub enum ResetError {
Copy link
Contributor

@ilstam ilstam Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this with the second patch where the error code is actually used

/// Reset is not implemented for the device.
NotImplemented,
}

/// Trait that helps in upcasting an object to Any
pub trait AsAny {
/// Return the immutable any encapsulated object.
Expand Down