Add clippy::cast_lossless

[StemCll]

Changes

Adds clippy::cast_lossless warning.

Reason

Closes #3196

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

• All commits in this PR are signed (git commit -s).
• If a specific issue led to this PR, this PR closes the issue.
• The description of changes is clear and encompassing.
• Any required documentation changes (code and docs) are included in this PR.
• New unsafe code is documented.
• API changes follow the Runbook for Firecracker API changes.
• User-facing changes are mentioned in CHANGELOG.md.
• All added/changed functionality is tested.

---

• This functionality can be added in rust-vmm.

[StemCll]

Hey @JonathanWoollett-Light I've fixed warnings for aarch64 CI

[JonathanWoollett-Light]

Great work!

On ARM you will need to update the code coverage values. Pick the outputs given in the failing tests (82.41 for 5.10 and 79.60 for 4.14) then paste these value as the new targets under tests/integration_tests/build/test_coverage.py.

I see some changes to tests/integration_tests/build/test_clippy.py are included, it would best to avoid changes to this in this PR.

[StemCll]

I've pushed the updated values in test_coverage.py.

Regarding the test_clippy.py - as far as I can see, the black is executed in pre-commit script. What should I do in this case? Add this file without executing black? 😄

[JonathanWoollett-Light]

the black is executed in pre-commit script. What should I do in this case? Add this file without executing black? 😄

Yep, using the --no-verify git commit argument should skip it.

It'd be worth opening a separate PR for the black reformat here.

[StemCll]

Separate PR for black reformat is ready here - #3232

I've reverted the formatting here.

Also - should this clippy lint be added to bindgen? Same as clippy::ptr_as_ptr?

[JonathanWoollett-Light]

Also - should this clippy lint be added to bindgen? Same as clippy::ptr_as_ptr?

It doesn't matter too much if it doesn't trigger any warnings, but I'd lean towards yes to avoid future errors.

[StemCll]

Done ✔️

[JonathanWoollett-Light]

Please squash all your changes into 1 commit for implementing the lint and 1 commit for the code coverage changes.

[StemCll]

done ✔️

[JonathanWoollett-Light]

You can rename the 2nd commit to simply Update code coverage for Arm.

[StemCll]

@JonathanWoollett-Light done ✔️

[JonathanWoollett-Light]

Getting failures for Arm coverage being higher, the 2nd commit needs to be adjusted to match (79.66 and 82.47 need to be set on Arm for 4.14 and 5.10 respectively).

Decided on way forward