Skip to content

Conversation

@arianbeh
Copy link
Contributor

This change enables the revive package-comments check and fixes the existing violations.

Changes:

  • Add package comments for packages that were missing them across runtime, snapshotter, internal utilities, and test helpers.
  • Remove the revive package-comments exclusion from .golangci.yml.

Verification:

  • make lint
  • go test ./...

Fixes #812.

@arianbeh arianbeh requested a review from a team as a code owner December 10, 2025 21:39
Copy link
Contributor

@sondavidb sondavidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linters pass, we're having trouble with our CI, I can merge this for now.

Thanks for the contribution!

@sondavidb sondavidb merged commit d6ffdaa into firecracker-microvm:main Dec 15, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve revive package-comments linter errors

2 participants