Skip to content

feat(genkit-tools/evals): Move metricsMetadata to eval run key #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(genkit-tools/evals): Move metricsMetadata to eval run key #3802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion genkit-tools/common/src/eval/evaluate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,10 @@ export async function runEvaluation(params: {
evalRunId,
createdAt: new Date().toISOString(),
metricSummaries,
metricsMetadata: metadata,
...augments,
},
results: scoredResults,
metricsMetadata: metadata,
};

logger.info('Finished evaluation, writing key...');
Expand Down
10 changes: 10 additions & 0 deletions genkit-tools/common/src/types/eval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,15 @@ export const EvalRunKeySchema = z.object({
createdAt: z.string(),
actionConfig: z.any().optional(),
metricSummaries: z.array(z.record(z.string(), z.any())).optional(),
metricsMetadata: z
.record(
z.string(),
z.object({
displayName: z.string(),
definition: z.string(),
})
)
.optional(),
});
export type EvalRunKey = z.infer<typeof EvalRunKeySchema>;
export const EvalKeyAugmentsSchema = EvalRunKeySchema.pick({
Expand All @@ -199,6 +208,7 @@ export type EvalKeyAugments = z.infer<typeof EvalKeyAugmentsSchema>;
export const EvalRunSchema = z.object({
key: EvalRunKeySchema,
results: z.array(EvalResultSchema),
/* deprecated, use key.metricsMetadata */
metricsMetadata: z
.record(
z.string(),
Expand Down
Loading