chore(js/evaluators): remove unnecessary path dependency #3587
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`path` is a core node module, and adding it as a dependency is pointless, as node (and other compatible runtimes) will always use the core module
10kc-emilyk
force-pushed
the
remove-unnecessary-path-dependency
branch
from
b24c688 to
3b11b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathis a core node module, and adding it as a dependency is pointless, as node (and other compatible runtimes) will always use the core moduleDescription here... Help the reviewer by:
Checklist (if applicable):
Docs updated (updated docs or a docs bug required)