New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js/plugins/google-cloud): Implement forceFlush and shutdown #1869

Open

schnecle wants to merge 1 commit into main from schnecle/metrics-shutdown-hooks

Contributor

schnecle commented Feb 5, 2025 •

edited

Loading

We were seeing occasions where flows run on Cloud functions are not exporting all metrics. We suspect that there are times where we were not waiting for metrics to complete because of the way that the cloud exporter exports asynchronously: https://github.com/GoogleCloudPlatform/opentelemetry-operations-js/blob/main/packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts#L117C53-L117C56

Adding a shutdown hook to our metrics wrapper ensures we are awaiting the callback function from the wrapped cloud exporter.

Manually tested locally using forceDevExport = true to make sure metrics are still being exported.

Checklist (if applicable):

PR title is following https://www.conventionalcommits.org/en/v1.0.0/
Tested (manually, unit tested, etc.)
Docs updated (updated docs or a docs bug required)


          fix(js/plugins/google-cloud): Implement forceFlush and shutdown hooks…

801608d

… for metrics.

github-actions bot added the js label

schnecle requested review from MichaelDoyle, pavelgj and kmandrika

February 5, 2025 21:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

js