Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile js-samples as part of tests #1855

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

i2amsam
Copy link
Contributor

@i2amsam i2amsam commented Feb 5, 2025

Following up from #1847 I realized that the samples are not getting compiled in CI to test for regressions. This adds a setup and build step to the samples that start with C. If this looks good, I'll include the other samples too.

Checklist (if applicable):

samples/js-coffee-shop/package.json Show resolved Hide resolved
samples/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@tonybaroneee tonybaroneee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing of beauty

🐚 🚢 🐑

@tonybaroneee
Copy link
Collaborator

tonybaroneee commented Feb 5, 2025

@pavelgj do we need to add "Build Samples" as a new blocking check in the repo config? Seems like maybe that config is out-of-date, only 3 of the 8 tasks are required to pass for submit.

@i2amsam i2amsam merged commit b084d77 into main Feb 5, 2025
8 checks passed
@i2amsam i2amsam deleted the complile-samples-as-part-of-tests branch February 5, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants