Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin node version using pnpm #1852 #1853

Closed
wants to merge 1 commit into from

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Feb 5, 2025

RATIONALE: Some older systems cannot be updated to use the latest version of system software and nodejs owing to access restrictions.

Pinning the version of node used by the project and allowing PNPM to manage the version of node is a suitable workaround.

ISSUE: #1852

CHANGELOG:

  • Update the .npmrc file to set the version of node used by the project.
  • Update the CONTRIBUTING.md file to include information about managed node versions.

Checklist (if applicable):

@yesudeep yesudeep requested a review from pavelgj February 5, 2025 07:17
@yesudeep yesudeep added this to the py-0.1.0 milestone Feb 5, 2025
@github-actions github-actions bot added docs Improvements or additions to documentation config fix root labels Feb 5, 2025
@yesudeep yesudeep self-assigned this Feb 5, 2025
@yesudeep yesudeep linked an issue Feb 5, 2025 that may be closed by this pull request
RATIONALE: Some older systems cannot be updated to use the latest
version of system software and nodejs owing to access
restrictions.

Pinning the version of node used by the project and allowing
PNPM to manage the version of node is a suitable workaround.

ISSUE: #1852

CHANGELOG:
- [ ] Update the .npmrc file to set the version of node used by the
  project.
- [ ] Update the CONTRIBUTING.md file to include information about
  managed node versions.
@yesudeep yesudeep force-pushed the yesudeep/fix/pnpm-managed-node branch from 715d60e to be8eed6 Compare February 5, 2025 07:18
@tonybaroneee
Copy link
Collaborator

tonybaroneee commented Feb 5, 2025

I'm not sure that we want to be in the business of mandating the node version on the user's machine like this, which causes a whole extra node installation which they may not want. There are projects like nvm that are better suited for this sort of thing. We support all versions of node above v20 and probably wouldn't want to stomp over whatever locally installed version someone wishes to use. In your case, I'd see if you could be granted to exception to use other versions of node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config docs Improvements or additions to documentation fix root
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Chore] Pin the version of node used with the project
2 participants