-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(go/core/tracing) doing enhancements for unit test in span data #1845
base: main
Are you sure you want to change the base?
Conversation
go/core/tracing/store_test.go
Outdated
func ensureAllSpanDataFieldsArePresent(t *testing.T, data Data, jsonMap map[string]any) { | ||
spans, ok := jsonMap["spans"].(map[string]any) | ||
if !ok { | ||
t.Errorf("expected 'spans' to be a map, but got %T", jsonMap["spans"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing t.Errorf(); return
you can use t.Fatalf()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the change, but we get rid of the t testing
I'm not sure how much value |
Description here... Help the reviewer by:
Checklist (if applicable):