Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GitHub actions for Python and pre-commit checks for go #1704 #1711

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat: add GitHub actions for Python and pre-commit checks for go #1704 #1711

merged 1 commit into from
Jan 30, 2025

Conversation

yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Jan 30, 2025 •
edited
Loading

Issue: #1704

Changelog:

  • Adds GitHub actions to check the PR for Python code changes
  • Adds pre-commit checks so that go tests pass per commit.
  • Configure prettier to ignore .mypy_cache/
  • Fixes formatting for some engdoc
  • Update py/bin/setup to add path to shell profile

Checklist (if applicable):

@yesudeep yesudeep requested a review from pavelgj January 30, 2025 06:19
@yesudeep yesudeep added this to the py-0.1.0 milestone Jan 30, 2025
@yesudeep yesudeep force-pushed the yesudeep/feat/python-github-actions branch 16 times, most recently from bb902b5 to a36859f Compare January 30, 2025 08:10
@yesudeep yesudeep force-pushed the yesudeep/feat/python-github-actions branch 2 times, most recently from c25eab0 to 4da573e Compare January 30, 2025 08:40
@yesudeep
feat: add GitHub actions for Python and pre-commit checks for go #1704
0296f0a 
Changelog:
- [ ] Adds GitHub actions to check the PR for Python code changes
      See: https://docs.astral.sh/uv/guides/integration/github/
- [ ] Adds pre-commit checks so that go tests pass per commit.
- [ ] Configure prettier to ignore .mypy_cache/
- [ ] Fixes formatting for some engdoc
- [ ] Updates the py/bin/setup script to work in CI environment
@yesudeep yesudeep force-pushed the yesudeep/feat/python-github-actions branch from 4da573e to 0296f0a Compare January 30, 2025 15:55
@yesudeep yesudeep merged commit bcfa4d8 into main Jan 30, 2025
4 checks passed
@yesudeep yesudeep deleted the yesudeep/feat/python-github-actions branch January 30, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

Assignees
No one assigned
Labels
ci python Python
Projects
Genkit Backlog
Status: Done
Milestone
py-0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yesudeep @pavelgj