-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): add image support to vertexai plugin #1429
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests and/or a sample that uses this? I see there are many more parameters in JS like watermark, aspect ratio, etc. How come these were omitted?
go/plugins/vertexai/vertexai.go
Outdated
@@ -169,6 +172,9 @@ func defineModel(name string, caps ai.ModelCapabilities) ai.Model { | |||
input *ai.ModelRequest, | |||
cb func(context.Context, *ai.ModelResponseChunk) error, | |||
) (*ai.ModelResponse, error) { | |||
if strings.HasPrefix(name, "imagen") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code block is auto-generated/copied from googleai.go so it's going to get overwritten. Can you figure out a way around it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just put outside of the code copied
Add support to vertexai plugin
Checklist (if applicable):