Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(go): update flow streaming protocol to SSE #1316

Merged
merged 19 commits into from
Jan 13, 2025

Conversation

hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented Nov 15, 2024

OK

curl -X POST -H "Accept: text/event-stream" http://localhost:3400/streamy -d '{"data":5}'
data: {"count":0}\n\n
data: {"count":1}\n\n
data: {"count":2}\n\n
data: {"count":3}\n\n
data: {"count":4}\n\n
data: {"result": "done: 5, streamed: 5 times"}\n\n

ERROR

curl -X POST -H "Accept: text/event-stream" http://localhost:3400/streamy -d '{"data":5}'                                                                       
data: {"message": {"count":0}}\n\n
data: {"message": {"count":1}}\n\n
data: {"message": {"count":2}}\n\n
data: {"message": {"count":3}}\n\n
data: {"message": {"count":4}}\n\n
data: {"error": {"status": "INTERNAL", "message": "stream flow error", "details": "this is a dummy error"}}\n\n         

Copy link

google-cla bot commented Nov 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pavelgj pavelgj changed the title [Go] Update flow streaming protocol to SSE breaking(go): update flow streaming protocol to SSE Nov 18, 2024
go/genkit/servers.go Outdated Show resolved Hide resolved
@hugoaguirre hugoaguirre force-pushed the haguirre/changeStreamFlowSSE branch from c7b91b2 to ebb72b8 Compare November 25, 2024 18:57
@hugoaguirre hugoaguirre marked this pull request as ready for review November 26, 2024 20:54
@hugoaguirre hugoaguirre linked an issue Nov 28, 2024 that may be closed by this pull request
@apascal07 apascal07 self-requested a review December 2, 2024 17:33
@hugoaguirre hugoaguirre self-assigned this Dec 11, 2024
@hugoaguirre hugoaguirre force-pushed the haguirre/changeStreamFlowSSE branch from 6043a56 to cb99b3c Compare December 20, 2024 22:04
@hugoaguirre hugoaguirre force-pushed the haguirre/changeStreamFlowSSE branch from da20f9a to fd19fac Compare January 10, 2025 20:06
@hugoaguirre
Copy link
Contributor Author

Go test cases failing due to unrelated errors, fix can be found here: #1595

@hugoaguirre hugoaguirre force-pushed the haguirre/changeStreamFlowSSE branch from 9f2761c to 34b6341 Compare January 13, 2025 22:20
@hugoaguirre hugoaguirre merged commit 1bf90ad into main Jan 13, 2025
5 checks passed
@hugoaguirre hugoaguirre deleted the haguirre/changeStreamFlowSSE branch January 13, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Go] Update streaming flows to server-sent events (SSE)
3 participants