fix(js/ai/prompt): also delete null description from input schema (#1691

)
firebase · Jan 29, 2025 · 76aa1df · 76aa1df
1 parent f6696da
commit 76aa1df
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/js/ai/src/prompt.ts b/js/ai/src/prompt.ts
@@ -739,7 +739,10 @@ function loadPrompt(
 
       // dotprompt can set null description on the schema, which can confuse downstream schema consumers
       if (promptMetadata.output?.schema?.description === null) {
-        delete promptMetadata.output?.schema?.description;
+        delete promptMetadata.output.schema.description;
+      }
+      if (promptMetadata.input?.schema?.description === null) {
+        delete promptMetadata.input.schema.description;
       }
 
       return {

diff --git a/js/genkit/tests/prompts_test.ts b/js/genkit/tests/prompts_test.ts
@@ -889,7 +889,7 @@ describe('definePrompt', () => {
   });
 });
 
-describe.only('prompt', () => {
+describe('prompt', () => {
   let ai: GenkitBeta;
   let pm: ProgrammableModel;
 
@@ -1031,6 +1031,16 @@ describe.only('prompt', () => {
       required: ['output'],
       type: 'object',
     });
+
+    assert.deepStrictEqual(
+      (await (await prompt.asTool())({ foo: 'bar' })).messages,
+      [
+        {
+          role: 'user',
+          content: [{ text: 'Write a poem about bar.' }],
+        },
+      ]
+    );
   });
 
   it('loads a varaint from from the folder', async () => {